Skip to content

[SPARK-38679][SQL][TESTS][FOLLOW-UP]Add numPartitions parameter to TaskContextImpl at SubexpressionEliminationSuite#36029

Closed
tedyu wants to merge 1 commit intoapache:masterfrom
tedyu:subex-ctx
Closed

[SPARK-38679][SQL][TESTS][FOLLOW-UP]Add numPartitions parameter to TaskContextImpl at SubexpressionEliminationSuite#36029
tedyu wants to merge 1 commit intoapache:masterfrom
tedyu:subex-ctx

Conversation

@tedyu
Copy link
Contributor

@tedyu tedyu commented Mar 31, 2022 •
edited
Loading

What changes were proposed in this pull request?

This PR adds missing numPartitions parameter for TaskContextImpl ctor.

Why are the changes needed?

This PR fixes build error:

spark/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala:426: not enough arguments for constructor TaskContextImpl: (stageId: Int, stageAttemptNumber: Int, partitionId: Int, taskAttemptId: Long, attemptNumber: Int, numPartitions: Int, taskMemoryManager: org.apache.spark.memory.TaskMemoryManager, localProperties: java.util.Properties, metricsSystem: org.apache.spark.metrics.MetricsSystem, taskMetrics: org.apache.spark.executor.TaskMetrics, cpus: Int, resources: Map[String,org.apache.spark.resource.ResourceInformation])org.apache.spark.TaskContextImpl.
Unspecified value parameter metricsSystem.

This was due to commit a40acd4 not being updated with latest TaskContextImpl ctor before merging.

Does this PR introduce any user-facing change?

No

How was this patch tested?

./build/mvn install -Phive -Phive-thriftserver -DskipTests

@github-actions github-actions bot added the SQL label Mar 31, 2022
@tedyu
Copy link
Contributor Author

tedyu commented Mar 31, 2022

@cloud-fan
Can you review this ?

martin-g
martin-g approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just debugging the same issue for #35976 (https://github.com/martin-g/spark/runs/5777391107?check_suite_focus=true)
Thank you, @tedyu !

@tedyu
Copy link
Contributor Author

tedyu commented Mar 31, 2022

@cloud-fan
Tests passed

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Mar 31, 2022

Oh, I just saw this open. I am closing mine #36031

@HyukjinKwon HyukjinKwon changed the title Fix missing argument for constructor TaskContextImpl [SPARK-38679][SQL][TESTS][FOLLOW-UP]Add numPartitions parameter to TaskContextImpl at SubexpressionEliminationSuite Mar 31, 2022
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Mar 31, 2022

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martin-g martin-g martin-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tedyu @HyukjinKwon @martin-g